[libcamera-devel] [PATCH 01/12] libcamera: Add Camera class

[Laurent Pinchart]

Hello,

On Friday, 28 December 2018 04:56:24 EET Niklas S??derlund wrote:
> On 2018-12-24 11:19:48 +0100, Jacopo Mondi wrote:
> > On Sun, Dec 23, 2018 at 12:00:30AM +0100, Niklas S??derlund wrote:
> > > Provide a Camera class which represents our main interface to handling
> > > camera devices. This is a rework of Kieran's initial proposal and
> > > Laurent's documentation of the file changed to fit the device
> > > enumerators needs.
> > > 
> > > Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
> > > ---
> > > 
> > >  include/libcamera/camera.h    | 31 +++++++++++
> > >  include/libcamera/libcamera.h |  2 +
> > >  include/libcamera/meson.build |  1 +
> > >  src/libcamera/camera.cpp      | 97 +++++++++++++++++++++++++++++++++++
> > >  src/libcamera/meson.build     |  1 +
> > >  5 files changed, 132 insertions(+)
> > >  create mode 100644 include/libcamera/camera.h
> > >  create mode 100644 src/libcamera/camera.cpp

[snip]

> > > diff --git a/include/libcamera/libcamera.h
> > > b/include/libcamera/libcamera.h
> > > index 790771b61e41e123..44c094d92feed5ba 100644
> > > --- a/include/libcamera/libcamera.h
> > > +++ b/include/libcamera/libcamera.h
> > > @@ -7,6 +7,8 @@
> > > 
> > >  #ifndef __LIBCAMERA_LIBCAMERA_H__
> > >  #define __LIBCAMERA_LIBCAMERA_H__
> > > 
> > > +#include <libcamera/camera.h>
> > > +
> > 
> > Why do you need this here?
> 
> The Camera object will be part of the public API and any application
> should only have to include the top header. Am I'm missing something?

libcamera.h should include all public headers, and serve as a shortcut for 
applications that want to pull in the whole public API. Applications can 
however include the other files separately as needed.

> > >  namespace libcamera {
> > >  
> > >  class libcamera

[snip]

-- 
Regards,

Laurent Pinchart