[libcamera-devel] [PATCH v2 09/12] libcamera: pipeline_handler: add PipelineHandler class

[Niklas Söderlund]

Hi Laurent,

All grammar comments addressed, thanks!

On 2018-12-30 23:15:43 +0200, Laurent Pinchart wrote:

[snip]

> > > > +/**
> > > > + * \brief Static global list of pipeline handlers
> > > > + *
> > > > + * It might seem odd to hide the static map inside a function.
> > > > + * This is needed to make sure the list is created before anyone
> > > > + * tries to access it and creating problems at link time.
> 
> No need to apologize about the oddity :-)
> 
> "The static factories map is defined inside the function to ensures it gets 
> initialized on first use, without any dependency on link order."

Much better! Thanks for providing this and your tag!

> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

-- 
Regards,
Niklas Söderlund