[libcamera-devel] [PATCH] meson: Describe minimum meson version requirements

[Laurent Pinchart]

Hi Kieran,

On Friday, 30 November 2018 17:22:20 EET Kieran Bingham wrote:
> On 30/11/2018 14:20, Laurent Pinchart wrote:
> > On Friday, 30 November 2018 11:48:02 EET Kieran Bingham wrote:
> >> We utilise 'add_project_arguments' which is only available in version
> >> 0.36 and 'build_by_default' which is only available in version 0.40 of
> >> meson.
> > 
> > Debian stable ships 0.37.1. Is there a chance we could replace
> > build_by_default with something else ? Otherwise, I'm fine with this patch
> > as it describes the reality.
> 
> Not that I can see. (as in to make it auto-build)
> 
> The only way to build the documentation if build_by_default isn't there
> is to run:
>   meson build
>   cd build
>   ninja Documentation/html
> 
> 
> Would you prefer to see documentation not get built unless it's
> explicitly asked for ?

I like that it gets built by default, so I'd prefer keeping this feature. It 
makes the documentation a first class citizen, as important as the code.

By the way, according to http://mesonbuild.com/Reference-manual.html#custom_target, build_by_default got introduced in v0.38, not 
v0.40. The source code however warns if the argument is used with a target 
version older than v0.40. I believe that's a bug, but we're stuck with it.

Let's thus commit this patch,

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> (which requires the build to know what they are asking to be built. ..
> but perhaps that's not a bad thing in a way)
> 
> >> Add this dependancy to the project requirements.
> >> 
> >> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> >> ---
> >> 
> >>  meson.build | 1 +
> >>  1 file changed, 1 insertion(+)
> >> 
> >> diff --git a/meson.build b/meson.build
> >> index 1e2bf9563515..e0aeefa30330 100644
> >> --- a/meson.build
> >> +++ b/meson.build
> >> @@ -1,4 +1,5 @@
> >>  project('libcamera - supporting complex camera pipelines', 'c', 'cpp',
> >> +  meson_version: '>= 0.40',
> >>    version : '0.1',
> >>    license : 'LGPL 2.1+')
> >>

-- 
Regards,

Laurent Pinchart