[libcamera-devel] [RFC 3/5] test: camera: Remove test for bad Stream IDs

[Laurent Pinchart]

Hi Niklas,

Thank you for the patch.

On Tue, Apr 02, 2019 at 02:53:30AM +0200, Niklas Söderlund wrote:
> In preparation of reworking how a default configuration is retrieved
> from a camera remove test that stream IDs must be valid as the data type
> passed to Camera::streamConfiguration() will change. This change is in
> preparation for a invasive change.

s/a invasive/an invasive/

> Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  test/camera/configuration_default.cpp | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/test/camera/configuration_default.cpp b/test/camera/configuration_default.cpp
> index 53ee021d33ca39b1..856cd415f7a6aec1 100644
> --- a/test/camera/configuration_default.cpp
> +++ b/test/camera/configuration_default.cpp
> @@ -49,19 +49,6 @@ protected:
>  			return TestFail;
>  		}
>  
> -		/*
> -		 * Test that asking for configuration for an array of bad streams
> -		 * returns an empty list of configurations.
> -		 */
> -		Stream *stream_bad = reinterpret_cast<Stream *>(0xdeadbeef);
> -		std::set<Stream *> streams_bad = { stream_bad };
> -		conf = camera_->streamConfiguration(streams_bad);
> -		if (!conf.empty()) {
> -			cout << "Failed to retrieve configuration for bad streams"
> -			     << endl;
> -			return TestFail;
> -		}
> -
>  		return TestPass;
>  	}
>  };

-- 
Regards,

Laurent Pinchart