[libcamera-devel] [RFC 4/5] libcamera: stream: Add basic stream usage hints definitions

[Niklas Söderlund]

Hi Laurent,

Thanks for your feedback.

On 2019-04-02 17:35:47 +0300, Laurent Pinchart wrote:
> > +};
> > +
> > +class Video : public StreamHint
> > +{
> > +public:
> > +	Video();
> > +};
> > +
> > +class Still : public StreamHint
> > +{
> > +public:
> > +	Still();
> > +};
> 
> Those are very generic names, and may lead to namespace clashes. You
> could isolate them in a separate namespace (possibly moving them to the
> Stream class), or rename them to StreamUsageViewfinder,
> StreamUsageVideoRecording and StreamUsageStillCapture.

I wrestled a lot with how to best handle this, for next version I went 
with moving the subclasses inside Stream class as it seems create then 
nicest interface for applications to use. Lets see how it works out.

-- 
Regards,
Niklas Söderlund