[libcamera-devel] [PATCH 3/5] test: camera: Remove test for bad Stream IDs

Niklas Söderlund niklas.soderlund at ragnatech.se
Wed Apr 3 03:12:19 CEST 2019


In preparation of reworking how a default configuration is retrieved
from a camera remove test that stream IDs must be valid as the data type
passed to Camera::streamConfiguration() will change. This change is in
preparation for an invasive change.

Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 test/camera/configuration_default.cpp | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/test/camera/configuration_default.cpp b/test/camera/configuration_default.cpp
index 53ee021d33ca39b1..856cd415f7a6aec1 100644
--- a/test/camera/configuration_default.cpp
+++ b/test/camera/configuration_default.cpp
@@ -49,19 +49,6 @@ protected:
 			return TestFail;
 		}
 
-		/*
-		 * Test that asking for configuration for an array of bad streams
-		 * returns an empty list of configurations.
-		 */
-		Stream *stream_bad = reinterpret_cast<Stream *>(0xdeadbeef);
-		std::set<Stream *> streams_bad = { stream_bad };
-		conf = camera_->streamConfiguration(streams_bad);
-		if (!conf.empty()) {
-			cout << "Failed to retrieve configuration for bad streams"
-			     << endl;
-			return TestFail;
-		}
-
 		return TestPass;
 	}
 };
-- 
2.21.0



More information about the libcamera-devel mailing list