[libcamera-devel] [PATCH v8 01/13] libcamera: geometry: Add 0-initialized SizeRange constructor

Jacopo Mondi jacopo at jmondi.org
Wed Apr 3 10:01:36 CEST 2019


Add constructor to SizeRange which initialize all the size range fields
to 0.

While at there make the in-line constructor declarations respect the
coding style by moving braces to a new line.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
---
 src/libcamera/geometry.cpp       | 11 ++++++++++-
 src/libcamera/include/geometry.h |  9 ++++++++-
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp
index 6dc8e74d2801..f76001d94562 100644
--- a/src/libcamera/geometry.cpp
+++ b/src/libcamera/geometry.cpp
@@ -73,7 +73,16 @@ const std::string Rectangle::toString() const
 
 /**
  * \fn SizeRange::SizeRange()
- * \brief Construct a size range
+ * \brief Construct a size range initialized to 0
+ */
+
+/**
+ * \fn SizeRange::SizeRange(unsigned int minW, unsigned int minH, unsigned int maxW, unsigned int maxH)
+ * \brief Construct an initialized size range
+ * \param minW The minimum width
+ * \param minH The minimum height
+ * \param maxW The maximum width
+ * \param maxH The maximum height
  */
 
 /**
diff --git a/src/libcamera/include/geometry.h b/src/libcamera/include/geometry.h
index b14f9732f3db..d8d587d3b47b 100644
--- a/src/libcamera/include/geometry.h
+++ b/src/libcamera/include/geometry.h
@@ -22,10 +22,17 @@ struct Rectangle {
 };
 
 struct SizeRange {
+	SizeRange()
+		: SizeRange(0, 0, 0, 0)
+	{
+	}
+
 	SizeRange(unsigned int minW, unsigned int minH,
 		  unsigned int maxW, unsigned int maxH)
 		: minWidth(minW), minHeight(minH), maxWidth(maxW),
-		  maxHeight(maxH) {}
+		  maxHeight(maxH)
+	{
+	}
 
 	unsigned int minWidth;
 	unsigned int minHeight;
-- 
2.21.0



More information about the libcamera-devel mailing list