[libcamera-devel] [PATCH 1/2] libcamera: ipu3: Catch return value when disabling links

Kieran Bingham kieran.bingham at ideasonboard.com
Wed Apr 3 12:25:44 CEST 2019


Ensure that any error from the disableLinks() call during match() is
propogated to the caller.

Fixes: d698ed27494a ("libcamera: ipu3: Create ImgUDevice class")
Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
---
 src/libcamera/pipeline/ipu3/ipu3.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
index 164e187c769d..fed04ce50387 100644
--- a/src/libcamera/pipeline/ipu3/ipu3.cpp
+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
@@ -511,7 +511,8 @@ bool PipelineHandlerIPU3::match(DeviceEnumerator *enumerator)
 	 * going through a library teardown->match() sequence would fail
 	 * at the moment.
 	 */
-	if (imguMediaDev_->disableLinks())
+	ret = imguMediaDev_->disableLinks();
+	if (ret)
 		goto error;
 
 	ret = registerCameras();
-- 
2.19.1



More information about the libcamera-devel mailing list