[libcamera-devel] [PATCH v4 08/12] libcamera: camera: Refuse empty requests

[Jacopo Mondi]

Requests that do not contain any Stream should not be forwarded to
the pipeline handlers. Return -EINVAL if the request does not contain
any Stream to capture from.

Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
---
 src/libcamera/camera.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp
index cb392ca3b7e7..bd73ff69c3da 100644
--- a/src/libcamera/camera.cpp
+++ b/src/libcamera/camera.cpp
@@ -728,6 +728,7 @@ Request *Camera::createRequest()
  * \return 0 on success or a negative error code otherwise
  * \retval -ENODEV The camera has been disconnected from the system
  * \retval -EACCES The camera is not running so requests can't be queued
+ * \retval -EINVAL The request does not contain any stream to capture from
  */
 int Camera::queueRequest(Request *request)
 {
@@ -743,6 +744,9 @@ int Camera::queueRequest(Request *request)
 		return ret;
 	}
 
+	if (request->empty())
+		return -EINVAL;
+
 	return pipe_->queueRequest(this, request);
 }
 
-- 
2.21.0