[libcamera-devel] [PATCH v4 05/12] libcamera: request: Expose the Stream to Buffers map

[Laurent Pinchart]

Hi Jacopo,

Thank you for the patch.

On Tue, Apr 09, 2019 at 09:25:41PM +0200, Jacopo Mondi wrote:
> Add to the Request class a method to access the map to Stream to Buffer.

s/to Stream/of Stream/

> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> ---
>  include/libcamera/request.h |  2 ++
>  src/libcamera/request.cpp   | 10 ++++++++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/include/libcamera/request.h b/include/libcamera/request.h
> index 0dbd425115e8..2004312a2233 100644
> --- a/include/libcamera/request.h
> +++ b/include/libcamera/request.h
> @@ -37,6 +37,8 @@ public:
>  
>  	Status status() const { return status_; }
>  
> +	const std::map<Stream *, Buffer *> &bufferMap() const { return bufferMap_; }
> +
>  private:
>  	friend class Camera;
>  	friend class PipelineHandler;
> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp
> index e0e77e972411..46f9add98fde 100644
> --- a/src/libcamera/request.cpp
> +++ b/src/libcamera/request.cpp
> @@ -106,6 +106,16 @@ Buffer *Request::findBuffer(Stream *stream) const
>   * \return The request completion status
>   */
>  
> +/**
> + * \fn Request::bufferMap()
> + * \brief Retrieve the request' stream to buffer map

s/request' stream to buffer/request's streams to buffer/

> + *
> + * Return a reference to the map that associates each Stream part of the
> + * request to the Buffer the Stream output should be directed to.
> + *
> + * \return The map of Stream to Buffers

If you use class names I wouldn't make them plural. "streams to buffers"
or "Stream to Buffer".

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> + */
> +
>  /**
>   * \brief Prepare the resources for the completion handler
>   */

-- 
Regards,

Laurent Pinchart