[libcamera-devel] [RFC 07/11] [HACK] tests: disable media_device_link_test

[Laurent Pinchart]

Hi Niklas,

Thank you for the patch.

On Sun, Apr 14, 2019 at 03:35:02AM +0200, Niklas Söderlund wrote:
> The test depends on the ability to access acquire() and release() of
> MediaDevice. These members are about to be made private and will no
> longer be cacheable to the test.
> 
> This needs to be solved as the test suite needs to be able to unit test
> classes properly. But for the purpose of this RFC lets disable it while
> it's figured out how to solve it.

As previously discussed, I think we can make test classes friends of the
implementation they test, probably with a LIBCAMERA_TEST_FRIEND() or
similar macro to only enable this behaviour when compiling tests.

> Not-Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
> ---
>  test/media_device/meson.build | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/test/media_device/meson.build b/test/media_device/meson.build
> index d91a022fab190abf..e4bedb79b572d655 100644
> --- a/test/media_device/meson.build
> +++ b/test/media_device/meson.build
> @@ -1,6 +1,5 @@
>  media_device_tests = [
>      ['media_device_print_test',         'media_device_print_test.cpp'],
> -    ['media_device_link_test',          'media_device_link_test.cpp'],
>  ]
>  
>  foreach t : media_device_tests

-- 
Regards,

Laurent Pinchart