[libcamera-devel] [PATCH v7 4/8] libcamera: v4l2_device: Propagate releaseBuffers() error
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Thu Apr 18 14:49:35 CEST 2019
Hi Jacopo,
Thank you for the patch.
On Wed, Apr 17, 2019 at 03:58:54PM +0200, Jacopo Mondi wrote:
> The error code returned by requestBuffers(0) was not propagated to the
> caller. Fix it.
>
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> src/libcamera/v4l2_device.cpp | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp
> index 4cc4a6d656b1..d394632dad4c 100644
> --- a/src/libcamera/v4l2_device.cpp
> +++ b/src/libcamera/v4l2_device.cpp
> @@ -737,10 +737,9 @@ int V4L2Device::releaseBuffers()
> {
> LOG(V4L2, Debug) << "Releasing bufferPool";
>
> - requestBuffers(0);
> bufferPool_ = nullptr;
>
> - return 0;
> + return requestBuffers(0);
> }
>
> /**
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list