[libcamera-devel] [PATCH v2 0/2] improve secure_getenv()

[Kieran Bingham]

Hi Guilio,

Thank you for the respin.
These look good to me, and the tests are now passing again.

For both of the patches,

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

There is a small comment from Laurent which I will apply locally before
pusing to master. Once this is done would you like to handle bumping the
buildroot package version?

Then hopefully the automated builds on buildroot will be fixed.
--
Regards

Kieran


On 26/04/2019 10:42, Giulio Benetti wrote:
> Local secure_getenv() at the moment uses getauxval(AT_SECURE), but it's
> not always present in libc and secure_getenv() instead could be.
> 
> Check if secure_getenv() is available from libc and use it, otherwise
> workaround it using issetugid().
> 
> Changes:
> V1->V2: 
> * improve meson.build
> * fix recursive secure_getenv()
> 
> Giulio Benetti (2):
>   meson: check if secure_getenv() is present
>   libcamera: utils: call secure_getenv() if it exists or workaround with
>     issetugid()
> 
>  meson.build             | 11 +++++++++++
>  src/libcamera/utils.cpp |  8 ++++++--
>  2 files changed, 17 insertions(+), 2 deletions(-)
> 

-- 
Regards
--
Kieran