[libcamera-devel] [PATCH 0/8] Fix clang compilation warnings and errors

Laurent Pinchart laurent.pinchart at ideasonboard.com
Fri Apr 26 17:01:47 CEST 2019


Hello,

This patch series fixes miscellaneous issues flagged by compiling
libcamera with clang. There isn't much to be said, I believe all issues
to be valid, please see individual patches for the fixes.

Laurent Pinchart (8):
  libcamera: Correct struct forward declarations
  libcamera: event_dispatcher_poll: Fix bitwise test
  libcamera: log: Add a LogInvalid entry to LogSeverity
  libcamera: Mark overridden functions with override
  libcamera: v4l2_device: Buffer is not a struct
  test: v4l2_subdevice: Remove std::move() that prevents copy elision
  cam: options: Don't initialise variable-length arrays
  cam: options: Fix string concatenation

 include/libcamera/camera.h                  |  3 ++-
 src/cam/options.cpp                         |  9 ++++++---
 src/libcamera/event_dispatcher_poll.cpp     |  2 +-
 src/libcamera/include/camera_sensor.h       |  3 ++-
 src/libcamera/include/log.h                 |  3 ++-
 src/libcamera/include/pipeline_handler.h    |  1 -
 src/libcamera/log.cpp                       | 14 +++++++-------
 src/libcamera/pipeline/ipu3/ipu3.cpp        |  2 +-
 src/libcamera/pipeline/uvcvideo.cpp         |  2 +-
 src/libcamera/pipeline/vimc.cpp             |  2 +-
 src/libcamera/v4l2_device.cpp               |  2 +-
 test/v4l2_subdevice/v4l2_subdevice_test.cpp |  2 +-
 12 files changed, 25 insertions(+), 20 deletions(-)

-- 
Regards,

Laurent Pinchart



More information about the libcamera-devel mailing list