[libcamera-devel] [PATCH 2/8] libcamera: event_dispatcher_poll: Fix bitwise test

Kieran Bingham kieran.bingham at ideasonboard.com
Fri Apr 26 18:02:38 CEST 2019


On 26/04/2019 17:01, Laurent Pinchart wrote:
> Add missing parentheses to fix a bitwise test.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  src/libcamera/event_dispatcher_poll.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/event_dispatcher_poll.cpp b/src/libcamera/event_dispatcher_poll.cpp
> index 130b5e20ea09..1f0f352a8e0a 100644
> --- a/src/libcamera/event_dispatcher_poll.cpp
> +++ b/src/libcamera/event_dispatcher_poll.cpp
> @@ -210,7 +210,7 @@ int EventDispatcherPoll::poll(std::vector<struct pollfd> *pollfds)
>  
>  void EventDispatcherPoll::processInterrupt(const struct pollfd &pfd)
>  {
> -	if (!pfd.revents & POLLIN)
> +	if (!(pfd.revents & POLLIN))
>  		return;
>  
>  	uint64_t value;
> 

-- 
Regards
--
Kieran


More information about the libcamera-devel mailing list