[libcamera-devel] [PATCH] libcamera: device_enumerator_udev: Include missing header

Jacopo Mondi jacopo at jmondi.org
Mon Apr 29 01:58:10 CEST 2019


Hi Laurent,

On Mon, Apr 29, 2019 at 02:23:22AM +0300, Laurent Pinchart wrote:
> The makedev() macro is defined in sys/sysmacros.h, include the header
> explicitly.

Thank you.

With this, we're only 1 error away to succesfully compile with the
clang version shipped by ChromeOS, so please push this.

Thanks
   j


>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  src/libcamera/device_enumerator_udev.cpp | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp
> index cb2d21b90506..86f6ca184698 100644
> --- a/src/libcamera/device_enumerator_udev.cpp
> +++ b/src/libcamera/device_enumerator_udev.cpp
> @@ -11,6 +11,7 @@
>  #include <libudev.h>
>  #include <string.h>
>  #include <sys/ioctl.h>
> +#include <sys/sysmacros.h>
>  #include <unistd.h>
>
>  #include <libcamera/event_notifier.h>
> --
> Regards,
>
> Laurent Pinchart
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20190429/f22e5be7/attachment.sig>


More information about the libcamera-devel mailing list