[libcamera-devel] [RFC 05/11] libcamera: media_device: Make open() and close() private

[Niklas Söderlund]

Hi Laurent,

Thanks for your feedback.

On 2019-04-17 02:14:54 +0300, Laurent Pinchart wrote:

snip

> > diff --git a/test/media_device/media_device_print_test.cpp 
> > b/test/media_device/media_device_print_test.cpp
> > index ceffd538e13fca73..30d929b8c76387a7 100644
> > --- a/test/media_device/media_device_print_test.cpp
> > +++ b/test/media_device/media_device_print_test.cpp
> > @@ -113,17 +113,6 @@ int MediaDevicePrintTest::testMediaDevice(const string deviceNode)
> >  	MediaDevice dev(deviceNode);
> >  	int ret;
> >  
> > -	/* Fuzzy open/close sequence. */
> 
> Do we need a fuzzy acquire/release sequence ?

That is a good idea, I will add this for v1 to replace this test.

> 
> > -	ret = dev.open();
> > -	if (ret)
> > -		return ret;
> > -
> > -	ret = dev.open();
> > -	if (!ret)
> > -		return ret;
> > -
> > -	dev.close();
> > -
> >  	ret = dev.populate();
> >  	if (ret)
> >  		return ret;
> 
> -- 
> Regards,
> 
> Laurent Pinchart

-- 
Regards,
Niklas Söderlund