[libcamera-devel] [PATCH 1/5] libcamera: pipeline_handler: Remove duplicated log from uvc and vimc

[Niklas Söderlund]

Hi Laurent,

Thanks for your work.

On 2019-04-30 21:37:42 +0300, Laurent Pinchart wrote:
> The uvcvideo and vimc pipeline handlers print the requested resolution
> in their configureStreams() operation. This duplicates a generic log
> statement in the Camera::configureStreams() method, remove it.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

> ---
>  src/libcamera/pipeline/uvcvideo.cpp | 3 ---
>  src/libcamera/pipeline/vimc.cpp     | 3 ---
>  2 files changed, 6 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp
> index 2f9b5e0fdc08..fd1d6df177d9 100644
> --- a/src/libcamera/pipeline/uvcvideo.cpp
> +++ b/src/libcamera/pipeline/uvcvideo.cpp
> @@ -109,9 +109,6 @@ int PipelineHandlerUVC::configureStreams(Camera *camera,
>  	const StreamConfiguration *cfg = &config[&data->stream_];
>  	int ret;
>  
> -	LOG(UVC, Debug) << "Configure the camera for resolution "
> -			<< cfg->width << "x" << cfg->height;
> -
>  	V4L2DeviceFormat format = {};
>  	format.width = cfg->width;
>  	format.height = cfg->height;
> diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp
> index f70b4d3c6bab..f95140661b2a 100644
> --- a/src/libcamera/pipeline/vimc.cpp
> +++ b/src/libcamera/pipeline/vimc.cpp
> @@ -109,9 +109,6 @@ int PipelineHandlerVimc::configureStreams(Camera *camera,
>  	const StreamConfiguration *cfg = &config[&data->stream_];
>  	int ret;
>  
> -	LOG(VIMC, Debug) << "Configure the camera for resolution "
> -			 << cfg->width << "x" << cfg->height;
> -
>  	V4L2DeviceFormat format = {};
>  	format.width = cfg->width;
>  	format.height = cfg->height;
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

-- 
Regards,
Niklas Söderlund