[libcamera-devel] [PATCH 2/5] meson: options: Add 'android' configuration option

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Aug 5 13:41:11 CEST 2019


Hi Jacopo,

Thank you for the patch.

On Thu, Aug 01, 2019 at 05:54:17PM +0200, Jacopo Mondi wrote:
> Add an 'android' configuration option, set to false by default, which
> enables the compilation of the Android HAL adaption layer on top of
> libcamera.
> 
> To enable compiling the Camera HAL wrapper in:
> $ meson configure -Dandroid=true
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> ---
>  meson_options.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/meson_options.txt b/meson_options.txt
> index 97efc85b4412..5fa8176b8e8b 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -1,3 +1,8 @@
> +option('android',
> +        type : 'boolean',
> +	value : false,
> +        description : 'Compile libcamera with Android Camera3 HAL interface')

Mixing tabs and space. Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

(I would have squashed this with 5/5, but I don't mind much if you want
to keep it separate)

> +
>  option('documentation',
>          type : 'boolean',
>          description : 'Generate the project documentation')

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list