[libcamera-devel] [PATCH 1/4] libcamera: pipeline: vimc: Initialize device pointers

[Laurent Pinchart]

Hi Niklas,

Thank you for the patch.

On Mon, Aug 05, 2019 at 05:51:30PM +0200, Niklas Söderlund wrote:
> As the device pointers are deleted in the pipelines destructor it's not
> a good idea to have them uninitialized.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/pipeline/vimc.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp
> index 61b68a32ea508af8..3d6808222a8a2c5d 100644
> --- a/src/libcamera/pipeline/vimc.cpp
> +++ b/src/libcamera/pipeline/vimc.cpp
> @@ -35,7 +35,7 @@ class VimcCameraData : public CameraData
>  {
>  public:
>  	VimcCameraData(PipelineHandler *pipe)
> -		: CameraData(pipe)
> +		: CameraData(pipe), video_(nullptr), sensor_(nullptr)
>  	{
>  	}
>  

-- 
Regards,

Laurent Pinchart