[libcamera-devel] [PATCH v3 5/6] test: v4l2_device: Remove unused function

Jacopo Mondi jacopo at jmondi.org
Tue Aug 13 12:20:54 CEST 2019


Hi Kieran,
  nice catch

Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

Thanks
   j

On Tue, Aug 13, 2019 at 10:40:19AM +0100, Kieran Bingham wrote:
> The 'exists()' call is not used within the code base.
> Remove it.
>
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  test/v4l2_videodevice/v4l2_videodevice_test.cpp | 11 -----------
>  1 file changed, 11 deletions(-)
>
> diff --git a/test/v4l2_videodevice/v4l2_videodevice_test.cpp b/test/v4l2_videodevice/v4l2_videodevice_test.cpp
> index a0d269fef7f4..096f9649bfc9 100644
> --- a/test/v4l2_videodevice/v4l2_videodevice_test.cpp
> +++ b/test/v4l2_videodevice/v4l2_videodevice_test.cpp
> @@ -6,7 +6,6 @@
>   */
>
>  #include <iostream>
> -#include <sys/stat.h>
>
>  #include <linux/media-bus-format.h>
>
> @@ -18,16 +17,6 @@
>  using namespace std;
>  using namespace libcamera;
>
> -bool exists(const std::string &path)
> -{
> -	struct stat sb;
> -
> -	if (stat(path.c_str(), &sb) == 0)
> -		return true;
> -
> -	return false;
> -}
> -
>  int V4L2VideoDeviceTest::init()
>  {
>  	enumerator_ = DeviceEnumerator::create();
> --
> 2.20.1
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20190813/de82525b/attachment.sig>


More information about the libcamera-devel mailing list