[libcamera-devel] [PATCH 3/3] readme: Provide build requirements

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Wed, Aug 14, 2019 at 10:58:17AM +0100, Kieran Bingham wrote:
> Provide an initial list of build dependancies for debian based systems.

s/debian based/Debian-based/

> Other distributions will be added separately.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
>  README.rst | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/README.rst b/README.rst
> index 0f64e076a9c0..1d4a84996d06 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -29,3 +29,24 @@ To build and install:
>    cd build
>    ninja
>    ninja install
> +
> +Dependencies
> +------------
> +
> +The following debian/ubuntu packages are required for building libcamera.

s/debian/Debian/
s/ubuntu/Ubuntu/

> +Other distributions may have differing package names:
> +
> +A C++ toolchain: [required]
> +	Either {g++, clang++}

I think the package is named clang, not clang++

> +
> +for libcamera: [required]
> +	meson ninja-build

meson depends on ninja-build, do we need to mention the latter
explicitly ? I don't mind if you think we should.

> +
> +for device hotplug enumeration: [optional]
> +	pkg-config libudev-dev
> +
> +for qcam: [optional]
> +	qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5
> +
> +for documentation: [optional]
> +	python3-sphinx doxygen

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

-- 
Regards,

Laurent Pinchart