[libcamera-devel] [PATCH 01/18] libcamera: object: Make message() method protected

[Niklas Söderlund]

Hi Laurent,

Thanks for your work.

On 2019-08-12 15:46:25 +0300, Laurent Pinchart wrote:
> The message() method shouldn't be called externally (except by a few
> friend classes), make it protected.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

> ---
>  include/libcamera/object.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/include/libcamera/object.h b/include/libcamera/object.h
> index 5c251a822d9a..3d08d69a9044 100644
> --- a/include/libcamera/object.h
> +++ b/include/libcamera/object.h
> @@ -26,11 +26,13 @@ public:
>  	virtual ~Object();
>  
>  	void postMessage(std::unique_ptr<Message> msg);
> -	virtual void message(Message *msg);
>  
>  	Thread *thread() const { return thread_; }
>  	void moveToThread(Thread *thread);
>  
> +protected:
> +	virtual void message(Message *msg);
> +
>  private:
>  	template<typename... Args>
>  	friend class Signal;
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

-- 
Regards,
Niklas Söderlund