[libcamera-devel] [PATCH 2/5] libcamera: controls: Add camera location control

[Niklas Söderlund]

Hi Jacopo,

Thanks for your patch.

On 2019-08-17 12:59:34 +0200, Jacopo Mondi wrote:
> Define a new libcamera control used to specify the camera location.
> Provide an enumeration of possible values to describe the "front",
> "back" and "external" camera locations.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> ---
>  include/libcamera/control_ids.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/libcamera/control_ids.h b/include/libcamera/control_ids.h
> index 75b6a2d5cafe..97ba11ec5f7b 100644
> --- a/include/libcamera/control_ids.h
> +++ b/include/libcamera/control_ids.h
> @@ -12,6 +12,12 @@
>  
>  namespace libcamera {
>  
> +enum CameraLocation {

Do we need a CAMERA_LOCATION_UNKNOWN to handle cases where this 
information is not available?

> +	CAMERA_LOCATION_FRONT,
> +	CAMERA_LOCATION_BACK,
> +	CAMERA_LOCATION_EXTERNAL,
> +};
> +
>  enum ControlId {
>  	AwbEnable,
>  	Brightness,
> @@ -19,6 +25,7 @@ enum ControlId {
>  	Saturation,
>  	ManualExposure,
>  	ManualGain,
> +	Location,
>  };
>  
>  } /* namespace libcamera */
> -- 
> 2.22.0
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

-- 
Regards,
Niklas Söderlund