[libcamera-devel] [PATCH 05/14] test: event-thread: Fix compilation on Chromium OS

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sun Aug 18 03:13:20 CEST 2019


Commit 92b4af98cd67 ("test: Add EventNotifier thread move test") causes
the build to fail in the Chromium OS build environment, because the
return values of the pipe() function marked with the
__warn_unused_result__ attribute is ignored. Fix this.

Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 test/event-thread.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/test/event-thread.cpp b/test/event-thread.cpp
index 714bc9845820..01120733eca4 100644
--- a/test/event-thread.cpp
+++ b/test/event-thread.cpp
@@ -25,7 +25,11 @@ public:
 	EventHandler()
 		: notified_(false)
 	{
-		pipe(pipefd_);
+		int ret = pipe(pipefd_);
+		if (ret < 0) {
+			ret = errno;
+			cout << "pipe() failed: " << strerror(ret) << endl;
+		}
 
 		notifier_ = new EventNotifier(pipefd_[0], EventNotifier::Read, this);
 		notifier_->activated.connect(this, &EventHandler::readReady);
-- 
Regards,

Laurent Pinchart



More information about the libcamera-devel mailing list