[libcamera-devel] [PATCH 01/14] libcamera: device_enumerator: Print media device name in error message

[Jacopo Mondi]

Hi Laurent,

On Sun, Aug 18, 2019 at 04:13:16AM +0300, Laurent Pinchart wrote:
> The device enumerator logs an error message when a media device is
> removed while still in use. Add the device name to the message to help
> debugging.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  src/libcamera/device_enumerator.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp
> index 6fcbae76b64e..60c918f0e26f 100644
> --- a/src/libcamera/device_enumerator.cpp
> +++ b/src/libcamera/device_enumerator.cpp
> @@ -166,7 +166,8 @@ DeviceEnumerator::~DeviceEnumerator()
>  	for (std::shared_ptr<MediaDevice> media : devices_) {
>  		if (media->busy())
>  			LOG(DeviceEnumerator, Error)
> -				<< "Removing media device while still in use";
> +				<< "Removing media device " << media->deviceNode()
> +				<< " while still in use";

just wondering if we want quotes around the media device name.

Apart for this minor
Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

>  	}
>  }
>
> --
> Regards,
>
> Laurent Pinchart
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20190819/dff3db0e/attachment.sig>