[libcamera-devel] [PATCH] meson: Rename 'tests' option to 'test'

[Jacopo Mondi]

Hi Laurent,

On Thu, Aug 22, 2019 at 12:09:50PM +0300, Laurent Pinchart wrote:
> The 'tests' option enables compilation of tests. On Gentoo and Chrome
> OS, the corresponding package USE flag is named 'test'. Rename the
> option to 'test' to bring it in line.

Seems reasonable to me to have the two flag names in sync.

Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

Thanks
  j

>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> We could also handle this in the libcamera ebuilds, but I think bringing
> the option name in line with common practices is a good idea. Any
> preference from anyone ?
>
>  meson.build       | 2 +-
>  meson_options.txt | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index 5201a2f5d78b..72ad7c8b493b 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -73,7 +73,7 @@ if get_option('documentation')
>      subdir('Documentation')
>  endif
>
> -if get_option('tests')
> +if get_option('test')
>      subdir('test')
>  endif
>
> diff --git a/meson_options.txt b/meson_options.txt
> index 2d78b8d91f9c..1a328045306c 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -7,6 +7,6 @@ option('documentation',
>          type : 'boolean',
>          description : 'Generate the project documentation')
>
> -option('tests',
> +option('test',
>          type : 'boolean',
>          description: 'Compile and include the tests')
> --
> Regards,
>
> Laurent Pinchart
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20190822/9a9d5cfe/attachment.sig>