[libcamera-devel] [PATCH] meson: Define _FORTIFY_SOURCE for non-debug builds

[Laurent Pinchart]

Hi Niklas,

On Mon, Aug 26, 2019 at 11:45:33PM +0200, Niklas Söderlund wrote:
> On 2019-08-19 16:02:45 +0300, Laurent Pinchart wrote:
> > _FORTIFY_SOURCE add useful checks during compilation. Enable it by
> > default, except for debug builds as it requires at least a -O1
> > optimisation level.
> 
> I think this is a good idea, it's a shame we can't have it enabled for 
> debug builds. My normal workflow of "meson build; ninja -C build" 
> produces debug builds so if this catch a problem it will be at release 
> time.

We could change the default build type too.

> > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> 
> Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
> 
> > ---
> >  meson.build | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/meson.build b/meson.build
> > index 13d0605f903c..53263d68791d 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -35,6 +35,12 @@ common_arguments = [
> >      '-include', 'config.h',
> >  ]
> >  
> > +if get_option('buildtype') != 'debug'
> > +    common_arguments += [
> > +        '-D_FORTIFY_SOURCE=1',
> > +    ]
> > +endif
> > +
> >  c_arguments = common_arguments
> >  cpp_arguments = common_arguments
> >  

-- 
Regards,

Laurent Pinchart