[libcamera-devel] [PATCH] libcamera: v4l2_device: Fix error messages in setControls()

[Jacopo Mondi]

Hi Niklas,
   ups, thanks for fixing this

On Thu, Aug 29, 2019 at 10:09:19AM +0200, Niklas Söderlund wrote:
> The error messages looks copied from getControls() without being updated
> for the set controls case, fix this.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

Acked-by: Jacopo Mondi <jacopo at jmondi.org>

Thanks
   j
> ---
>  src/libcamera/v4l2_device.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp
> index f89546610ac69ba0..349bf2d2970418e4 100644
> --- a/src/libcamera/v4l2_device.cpp
> +++ b/src/libcamera/v4l2_device.cpp
> @@ -287,13 +287,13 @@ int V4L2Device::setControls(V4L2ControlList *ctrls)
>
>  		/* Generic validation error. */
>  		if (errorIdx == 0 || errorIdx >= count) {
> -			LOG(V4L2, Error) << "Unable to read controls: "
> +			LOG(V4L2, Error) << "Unable to set controls: "
>  					 << strerror(ret);
>  			return -EINVAL;
>  		}
>
>  		/* A specific control failed. */
> -		LOG(V4L2, Error) << "Unable to read control " << errorIdx
> +		LOG(V4L2, Error) << "Unable to set control " << errorIdx
>  				 << ": " << strerror(ret);
>  		count = errorIdx - 1;
>  		ret = errorIdx;
> --
> 2.22.1
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20190829/f01f7f5b/attachment.sig>