[libcamera-devel] [PATCH 11/30] libcamera: v4l2_videodevice: Align which type variable is used in queueBuffer()

[Jacopo Mondi]

Hi Niklas,
   sorry for the double comment

On Wed, Nov 27, 2019 at 03:48:33PM +0100, Jacopo Mondi wrote:
> Hi Niklas,
>
> On Wed, Nov 27, 2019 at 12:36:01AM +0100, Niklas Söderlund wrote:
> > Reading V4L2VideoDevice::queueBuffer() is confusing since buf.type is
> > first set to bufferType_ but then both variables are used in V4L2 macros
> > to operate based on which type of buffer is being processed. Aligen on

s/Aligen/Align

Thanks
   j

> > only using buf.type since it have the most existing users.
>
> I'm not sure which one of the two is mostly used to be honest.
>
> This change won't hurt though if you want it in.
> Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>
>
> Thanks
>   j
>
> >
> > Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
> > ---
> >  src/libcamera/v4l2_videodevice.cpp | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp
> > index 166b0abc1b101f88..7b6fa5347ef320f8 100644
> > --- a/src/libcamera/v4l2_videodevice.cpp
> > +++ b/src/libcamera/v4l2_videodevice.cpp
> > @@ -1000,7 +1000,7 @@ int V4L2VideoDevice::queueBuffer(Buffer *buffer)
> >  		buf.m.planes = v4l2Planes;
> >  	}
> >
> > -	if (V4L2_TYPE_IS_OUTPUT(bufferType_)) {
> > +	if (V4L2_TYPE_IS_OUTPUT(buf.type)) {
> >  		buf.bytesused = buffer->bytesused_;
> >  		buf.sequence = buffer->sequence_;
> >  		buf.timestamp.tv_sec = buffer->timestamp_ / 1000000000;
> > --
> > 2.24.0
> >
> > _______________________________________________
> > libcamera-devel mailing list
> > libcamera-devel at lists.libcamera.org
> > https://lists.libcamera.org/listinfo/libcamera-devel



> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20191202/38ac92f6/attachment.sig>