[libcamera-devel] [PATCH 5/7] libcamera: v4l2_device: Zero-initialize V4L2 format

[Kieran Bingham]

Hi Jacopo,

On 01/02/2019 16:42, Jacopo Mondi wrote:
> Zero initialize v4l2_format structures used to set and get format on the
> V4L2 device.

Because this one could also cause undesired behaviour, I think this too
deserves a fixes tag:

Fixes: ba8da0f2fcd0 ("libcamera: v4l2_device: Add methods to get/set
format")

Otherwise,

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>


> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> ---
>  src/libcamera/v4l2_device.cpp | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp
> index 0d4d60f..b86a629 100644
> --- a/src/libcamera/v4l2_device.cpp
> +++ b/src/libcamera/v4l2_device.cpp
> @@ -299,7 +299,7 @@ int V4L2Device::setFormat(V4L2DeviceFormat *format)
>  
>  int V4L2Device::getFormatSingleplane(V4L2DeviceFormat *format)
>  {
> -	struct v4l2_format v4l2Format;
> +	struct v4l2_format v4l2Format = {};
>  	struct v4l2_pix_format *pix = &v4l2Format.fmt.pix;
>  	int ret;
>  
> @@ -323,7 +323,7 @@ int V4L2Device::getFormatSingleplane(V4L2DeviceFormat *format)
>  
>  int V4L2Device::setFormatSingleplane(V4L2DeviceFormat *format)
>  {
> -	struct v4l2_format v4l2Format;
> +	struct v4l2_format v4l2Format = {};
>  	struct v4l2_pix_format *pix = &v4l2Format.fmt.pix;
>  	int ret;
>  
> @@ -344,7 +344,7 @@ int V4L2Device::setFormatSingleplane(V4L2DeviceFormat *format)
>  
>  int V4L2Device::getFormatMultiplane(V4L2DeviceFormat *format)
>  {
> -	struct v4l2_format v4l2Format;
> +	struct v4l2_format v4l2Format = {};
>  	struct v4l2_pix_format_mplane *pix = &v4l2Format.fmt.pix_mp;
>  	int ret;
>  
> @@ -371,7 +371,7 @@ int V4L2Device::getFormatMultiplane(V4L2DeviceFormat *format)
>  
>  int V4L2Device::setFormatMultiplane(V4L2DeviceFormat *format)
>  {
> -	struct v4l2_format v4l2Format;
> +	struct v4l2_format v4l2Format = {};
>  	struct v4l2_pix_format_mplane *pix = &v4l2Format.fmt.pix_mp;
>  	int ret;
>  
> 

-- 
Regards
--
Kieran