[libcamera-devel] [PATCH 10/27] libcamera: v4l2_device: Add comments to method parameters

Laurent Pinchart laurent.pinchart at ideasonboard.com
Wed Feb 6 07:08:01 CET 2019


From: Jacopo Mondi <jacopo at jmondi.org>

Add missing parameter documentation for set and get format methods.

Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 src/libcamera/v4l2_device.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp
index e8755be1f63f..64325ff9f5d9 100644
--- a/src/libcamera/v4l2_device.cpp
+++ b/src/libcamera/v4l2_device.cpp
@@ -352,6 +352,8 @@ void V4L2Device::close()
 
 /**
  * \brief Retrieve the image format set on the V4L2 device
+ * \param[out] format The image format applied on the device
+ *
  * \return 0 for success, a negative error code otherwise
  */
 int V4L2Device::getFormat(V4L2DeviceFormat *format)
@@ -362,6 +364,7 @@ int V4L2Device::getFormat(V4L2DeviceFormat *format)
 
 /**
  * \brief Configure an image format on the V4L2 device
+ * \param[in] format The image format to apply to the device
  *
  * Apply the supplied \a format to the device, and return the actually
  * applied format parameters, as \ref V4L2Device::getFormat would do.
-- 
Regards,

Laurent Pinchart



More information about the libcamera-devel mailing list