[libcamera-devel] [PATCH 1/4] libcamera: v4l2_subdevice: Forward-declare MediaEntity

[Laurent Pinchart]

Hi Jacopo,

Thank you for the patch.

On Tue, Feb 12, 2019 at 11:20:18PM +0100, Jacopo Mondi wrote:
> The V4L2Subdevice class uses MediaEntity instances, and the
> corresponding header is not included.
> 
> Fix this by forward declaring the MediaEntity class.
> 
> Fixes: 468176fa07d9 ("libcamera: Add V4L2Subdevice")
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> ---
>  src/libcamera/include/v4l2_subdevice.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/libcamera/include/v4l2_subdevice.h b/src/libcamera/include/v4l2_subdevice.h
> index 8fd666078985..ffa92100ffbc 100644
> --- a/src/libcamera/include/v4l2_subdevice.h
> +++ b/src/libcamera/include/v4l2_subdevice.h
> @@ -12,6 +12,7 @@
>  namespace libcamera {
>  
>  struct Rectangle;
> +class MediaEntity;

Should we sort this alphabetically ? Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

>  
>  struct V4L2SubdeviceFormat {
>  	uint32_t mbus_code;

-- 
Regards,

Laurent Pinchart