[libcamera-devel] [PATCH v3 2/3] test: v4l2_device: release capture device resources

Laurent Pinchart laurent.pinchart at ideasonboard.com
Wed Feb 13 18:23:03 CET 2019


Hi Kieran,

Thank you for the patch.

On Wed, Feb 13, 2019 at 05:14:52PM +0000, Kieran Bingham wrote:
> Ensure that the cleanup operation releases the device and resources.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  test/v4l2_device/v4l2_device_test.cpp | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/test/v4l2_device/v4l2_device_test.cpp b/test/v4l2_device/v4l2_device_test.cpp
> index 2bdf8cfe983a..4225291bbb6e 100644
> --- a/test/v4l2_device/v4l2_device_test.cpp
> +++ b/test/v4l2_device/v4l2_device_test.cpp
> @@ -63,5 +63,9 @@ void V4L2DeviceTest::cleanup()
>  {
>  	media_->release();
>  
> +	capture_->streamOff();
> +	capture_->releaseBuffers();
> +	capture_->close();
> +
>  	delete capture_;
>  };

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list