[libcamera-devel] [PATCH v5 9/9] test: v4l2_device: Add format handling test

Jacopo Mondi jacopo at jmondi.org
Thu Feb 28 21:01:51 CET 2019


Add test for V4L2Device set and get format methods.

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
---
 test/v4l2_device/formats.cpp | 53 ++++++++++++++++++++++++++++++++++++
 test/v4l2_device/meson.build |  1 +
 2 files changed, 54 insertions(+)
 create mode 100644 test/v4l2_device/formats.cpp

diff --git a/test/v4l2_device/formats.cpp b/test/v4l2_device/formats.cpp
new file mode 100644
index 000000000000..30b8b5c3f3f5
--- /dev/null
+++ b/test/v4l2_device/formats.cpp
@@ -0,0 +1,53 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+/*
+ * Copyright (C) 2019, Google Inc.
+ *
+ * libcamera V4L2 device format handling test
+ */
+
+#include <climits>
+#include <iostream>
+
+#include "v4l2_device.h"
+
+#include "v4l2_device_test.h"
+
+using namespace std;
+using namespace libcamera;
+
+class Format : public V4L2DeviceTest
+{
+protected:
+	int run() override;
+};
+
+int Format::run()
+{
+	V4L2DeviceFormat format = {};
+
+	int ret = capture_->getFormat(&format);
+	if (ret) {
+		cerr << "Failed to get format" << endl;
+		return TestFail;
+	}
+
+	format.width = UINT_MAX;
+	format.height = UINT_MAX;
+	ret = capture_->setFormat(&format);
+	if (ret) {
+		cerr << "Failed to set format: image resolution is invalid: "
+		     << "(UINT_MAX x UINT_MAX) but setFormat() should not fail."
+		     << endl;
+		return TestFail;
+	}
+
+	if (format.width == UINT_MAX || format.height == UINT_MAX) {
+		cerr << "Failed to update image format = (UINT_MAX x UINT_MAX)"
+		     << endl;
+		return TestFail;
+	}
+
+	return TestPass;
+}
+
+TEST_REGISTER(Format);
diff --git a/test/v4l2_device/meson.build b/test/v4l2_device/meson.build
index 9f7a7545ac9b..aa617b6dc837 100644
--- a/test/v4l2_device/meson.build
+++ b/test/v4l2_device/meson.build
@@ -2,6 +2,7 @@
 # They are not alphabetically sorted.
 v4l2_device_tests = [
   [ 'double_open',        'double_open.cpp' ],
+  [ 'formats',            'formats.cpp' ],
   [ 'request_buffers',    'request_buffers.cpp' ],
   [ 'stream_on_off',      'stream_on_off.cpp' ],
   [ 'capture_async',      'capture_async.cpp' ],
-- 
2.20.1



More information about the libcamera-devel mailing list