[libcamera-devel] [PATCH 1/2] libcamera: media_device: Tiny valid() documentation improvement

Laurent Pinchart laurent.pinchart at ideasonboard.com
Wed Jan 2 12:11:31 CET 2019


Hi Jacopo,

Thank you for the patch.

On Wednesday, 2 January 2019 13:00:15 EET Jacopo Mondi wrote:
> Mention in the valid() method documentation, that a media graph has to
> be populated to be valid.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Please push.

> ---
>  src/libcamera/media_device.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp
> index 1bd4f43..9fbc5a7 100644
> --- a/src/libcamera/media_device.cpp
> +++ b/src/libcamera/media_device.cpp
> @@ -216,7 +216,7 @@ int MediaDevice::populate()
> 
>  /**
>   * \fn MediaDevice::valid()
> - * \brief Query whether the media graph is valid
> + * \brief Query whether the media graph has been populated and is valid
>   * \return true if the media graph is valid, false otherwise
>   */

-- 
Regards,

Laurent Pinchart





More information about the libcamera-devel mailing list