[libcamera-devel] [PATCH v2 02/12] libcamera: add dependency on libudev

[Laurent Pinchart]

Hi Kieran,

On Wednesday, 9 January 2019 19:07:29 EET Kieran Bingham wrote:
> On 29/12/2018 03:28, Niklas Söderlund wrote:
> > The device enumeration will depend on libudev, add the dependency to the
> > build system. This should be turned into a optional dependency once a
> > device enumerator not using udev is supported.
> > 
> > Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > ---
> > 
> >  src/libcamera/meson.build | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
> > index 46591069aa5f8beb..52b556a8ed4050cb 100644
> > --- a/src/libcamera/meson.build
> > +++ b/src/libcamera/meson.build
> > @@ -16,7 +16,10 @@ includes = [
> >      libcamera_internal_includes,
> >  ]
> > 
> > +libudev = dependency('libudev')
> > +
> 
> The website currently states that we will not depend on anything except
> the standard libraries [0].

It also states "If other dependencies are deemed to be useful during 
development they shall be proposed and reviewed." :-) Note that we should make 
this dependency optional.

> I guess this will be updated when we move the website to build from the
> repo, although I can't see anywhere within Documentation listing
> anything similar. Is there a section missing in our source level docs?

The rest of the section has been added to the coding style document, but this 
particular bullet point is missing. It doesn't belong to the coding style in 
my opinion. Any idea on who to structure the documentation to give it a home ?

> [0] http://www.libcamera.org/docs.html#technical-requirements
> 
> >  libcamera = shared_library('camera',
> >                             libcamera_sources,
> >                             install : true,
> > -                           include_directories : includes)
> > +                           include_directories : includes,
> > +                           dependencies : libudev)

-- 
Regards,

Laurent Pinchart