[libcamera-devel] [PATCH v2] meson: Utilise default compiler options

[Niklas Söderlund]

Hi Kieran,

On 2019-01-15 21:36:50 +0000, Kieran Bingham wrote:
> Hi Niklas,
> 
> On 15/01/2019 21:15, Niklas Söderlund wrote:
> > Hi Kieran,
> > 
> > Thanks for your work.
> > 
> > On 2019-01-14 22:32:48 +0000, Kieran Bingham wrote:
> >> Remove our custom declarations for cpp_std=c++11, -Wall, -Wextra and
> >> -Werror, instead prefering to use the built-in default_option parameters
> >> from meson.
> >>
> >> Our custom compiler flags (such as -Wno-unused-parameter) are
> >> maintained.
> >>
> >> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> >> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> > 
> > Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
> > 
> 
> Thank you - I'm sorry - I pushed before I saw your tag.

No worries, less things I can be blamed for not having noticed :-)

> 
> --
> Kieran
> 
> >>
> >> ---
> >> v2:
> >>  - Remove duplicated -Wall, -Wextra flags which are provided at
> >>    warning_level=2
> >>
> >>  meson.build | 9 +++++----
> >>  1 file changed, 5 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/meson.build b/meson.build
> >> index 0ab0da981083..4465a3851a30 100644
> >> --- a/meson.build
> >> +++ b/meson.build
> >> @@ -1,6 +1,11 @@
> >>  project('libcamera', 'c', 'cpp',
> >>    meson_version: '>= 0.40',
> >>    version : '0.1',
> >> +  default_options: [
> >> +    'werror=true',
> >> +    'warning_level=2',
> >> +    'cpp_std=c++11',
> >> +  ],
> >>    license : 'LGPL 2.1+')
> >>  
> >>  # TODO: Extract this from project.version.
> >> @@ -9,15 +14,11 @@ project('libcamera', 'c', 'cpp',
> >>  api_version = '0.1'
> >>  
> >>  common_arguments = [
> >> -    '-Wall',
> >> -    '-Wextra',
> >> -    '-Werror',
> >>      '-Wno-unused-parameter',
> >>  ]
> >>  
> >>  c_arguments = common_arguments
> >>  cpp_arguments = common_arguments
> >> -cpp_arguments += '-std=c++11'
> >>  
> >>  add_project_arguments(c_arguments, language: 'c')
> >>  add_project_arguments(cpp_arguments, language: 'cpp')
> >> -- 
> >> 2.17.1
> >>
> >> _______________________________________________
> >> libcamera-devel mailing list
> >> libcamera-devel at lists.libcamera.org
> >> https://lists.libcamera.org/listinfo/libcamera-devel
> > 
> 
> -- 
> Regards
> --
> Kieran

-- 
Regards,
Niklas Söderlund