[libcamera-devel] [PATCH 1/5] test: timer: Initialise all variables

Kieran Bingham kieran.bingham at ideasonboard.com
Thu Jan 17 21:20:39 CET 2019


The ManagedTimer does not initialise the integer 'interval_' variable.

This is set before used, and should not break - but for completeness
(and to cover static analysers) initialise the variable in the
initialiser list.

Fixes: 034ea868027d ("test: Add timer test")
Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
---
 test/timer.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/test/timer.cpp b/test/timer.cpp
index 6a3cda70bef4..3d1a78ac2768 100644
--- a/test/timer.cpp
+++ b/test/timer.cpp
@@ -19,7 +19,8 @@ using namespace libcamera;
 class ManagedTimer : public Timer
 {
 public:
-	ManagedTimer() : Timer()
+	ManagedTimer() :
+		Timer(), interval_(0)
 	{
 		timeout.connect(this, &ManagedTimer::timeoutHandler);
 	}
-- 
2.17.1



More information about the libcamera-devel mailing list