[libcamera-devel] [PATCH] libcamera: camera_manager: Return EBUSY if enumerator exists

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Mon, Jan 21, 2019 at 11:41:26AM +0000, Kieran Bingham wrote:
> In the case that someone calls CameraManager::start() and it has already
> started/enumerated, instead of returning -ENODEV, return -EBUSY.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/camera_manager.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp
> index d76eaa7ace86..21cb36dcb9b5 100644
> --- a/src/libcamera/camera_manager.cpp
> +++ b/src/libcamera/camera_manager.cpp
> @@ -76,7 +76,7 @@ CameraManager::~CameraManager()
>  int CameraManager::start()
>  {
>  	if (enumerator_)
> -		return -ENODEV;
> +		return -EBUSY;
>  
>  	enumerator_ = DeviceEnumerator::create();
>  	if (enumerator_->enumerate())

-- 
Regards,

Laurent Pinchart