[libcamera-devel] [PATCH v2 4/4] libcamera: Use log categories

[Laurent Pinchart]

Hi Jacopo,

On Tue, Jan 22, 2019 at 09:48:27AM +0100, Jacopo Mondi wrote:
> On Mon, Jan 21, 2019 at 09:56:06PM +0200, Laurent Pinchart wrote:
> > Use log categories in the whole existing code base.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > ---
> >  src/libcamera/camera_manager.cpp        | 14 ++++---
> >  src/libcamera/device_enumerator.cpp     | 25 +++++++-----
> >  src/libcamera/event_dispatcher.cpp      |  4 ++
> >  src/libcamera/event_dispatcher_poll.cpp | 28 +++++++------
> >  src/libcamera/media_device.cpp          | 52 +++++++++++++++----------
> >  src/libcamera/media_object.cpp          |  7 +++-
> >  src/libcamera/pipeline_handler.cpp      |  5 ++-
> >  src/libcamera/timer.cpp                 |  7 +++-
> >  src/libcamera/v4l2_device.cpp           | 25 +++++++-----
> >  9 files changed, 107 insertions(+), 60 deletions(-)
> >
> 
> [snip]
> 
> > diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp
> > index 55c510e3b79a..22d4edee1cb2 100644
> > --- a/src/libcamera/device_enumerator.cpp
> > +++ b/src/libcamera/device_enumerator.cpp
> 
> It seems to me line 97:
> 	LOG(Debug) << "Found a match with " << log::quoted(name);
> 
> has not been changed to use categories. Was this intentional?

I see no such code in the master branch :-)

-- 
Regards,

Laurent Pinchart