[libcamera-devel] [PATCH 2/4] libcamera: event_dispatcher_poll: Handle interrupted ppoll() calls

Kieran Bingham kieran.bingham at ideasonboard.com
Wed Jan 23 14:25:49 CET 2019


In addendum

On 23/01/2019 11:30, Kieran Bingham wrote:
> Hi Laurent,

<snip>

>> +	return ppoll(pollfds->data(), pollfds->size(),
>> +		     nextTimer ? &timeout : nullptr, nullptr);
> 
> I see comparisons (particularly from a table in Michael Kerrisk's kernel
> interface book) looking at how epoll is much better than poll/select
> when there are more than about 10 fds to consider...
> 
> I wonder how many FDs we'll end up monitoring in our event code...
> Especially as external code will likely use our event loop.
> 
> One day it might be worth looking at the comparisons, but I don't think
> today is that day.

I think that might deserve it's own implementation, so that would be:

class EventDispatcherEpoll;

- not this class anyway :)
--
Kieran

<snip>


More information about the libcamera-devel mailing list