[libcamera-devel] [PATCH 02/10] libcamera: pipeline_handler: Declare factory children classes as final

Laurent Pinchart laurent.pinchart at ideasonboard.com
Thu Jan 24 11:16:43 CET 2019


Nothing should inherit from the factory classes created by the
REGISTER_PIPELINE_HANDLER() macro. Declare them as final instead of only
declaring their create() method final.

Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 src/libcamera/include/pipeline_handler.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h
index 7bb07d1ec5c7..1da6dc758ca6 100644
--- a/src/libcamera/include/pipeline_handler.h
+++ b/src/libcamera/include/pipeline_handler.h
@@ -46,11 +46,11 @@ private:
 };
 
 #define REGISTER_PIPELINE_HANDLER(handler)				\
-class handler##Factory : public PipelineHandlerFactory			\
+class handler##Factory final : public PipelineHandlerFactory		\
 {									\
 public:									\
 	handler##Factory() : PipelineHandlerFactory(#handler) {}	\
-	PipelineHandler *create(CameraManager *manager) final		\
+	PipelineHandler *create(CameraManager *manager) 		\
 	{								\
 		return new handler(manager);				\
 	}								\
-- 
Regards,

Laurent Pinchart



More information about the libcamera-devel mailing list