[libcamera-devel] [PATCH] cam: options: optional arguments needs to be specified as --foo=bar
Niklas Söderlund
niklas.soderlund at ragnatech.se
Fri Jan 25 00:23:11 CET 2019
It's not state in the documentation but optional arguments needs to be
specified using as '--foo=bar' instead of '--foo bar', otherwise the
value is not propagated to optarg during argument parsing. Update the
usage printing helper to reflect this requirement.
Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
---
src/cam/options.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/cam/options.cpp b/src/cam/options.cpp
index 82acff9bbeea476d..73d81d0bc0ec6d38 100644
--- a/src/cam/options.cpp
+++ b/src/cam/options.cpp
@@ -143,7 +143,8 @@ void OptionsParser::usage()
};
if (option.argument != ArgumentNone) {
- argument += std::string(" ");
+ argument += option.argument == ArgumentOptional ?
+ "=" : " ";
if (option.argument == ArgumentOptional)
argument += "[";
argument += option.argumentName;
--
2.20.1
More information about the libcamera-devel
mailing list