[libcamera-devel] [PATCH] libcamera: pipeline: uvcvideo: add warning if no default video device is found

Niklas Söderlund niklas.soderlund at ragnatech.se
Sun Jan 27 01:52:06 CET 2019


If for any reason a default video device is not found in the media graph
the creation of the UVC pipeline silently failed. This is not optimal
when debugging problems with the pipeline, add a warning to notify the
user of the issue.

Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
---
 src/libcamera/pipeline/uvcvideo.cpp | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp
index c51e8bc1f2c2bf25..4ae179d24709c856 100644
--- a/src/libcamera/pipeline/uvcvideo.cpp
+++ b/src/libcamera/pipeline/uvcvideo.cpp
@@ -8,12 +8,15 @@
 #include <libcamera/camera.h>
 
 #include "device_enumerator.h"
+#include "log.h"
 #include "media_device.h"
 #include "pipeline_handler.h"
 #include "v4l2_device.h"
 
 namespace libcamera {
 
+LOG_DEFINE_CATEGORY(UVC)
+
 class PipelineHandlerUVC : public PipelineHandler
 {
 public:
@@ -60,6 +63,9 @@ bool PipelineHandlerUVC::match(DeviceEnumerator *enumerator)
 	}
 
 	if (!video_ || video_->open()) {
+		if (!video_)
+			LOG(UVC, Warning) << "Could not find a default video device";
+
 		media_->release();
 		return false;
 	}
-- 
2.20.1



More information about the libcamera-devel mailing list