[libcamera-devel] [PATCH] clang-format: Set ColumnLimit to 80

[Kieran Bingham]

Hi Laurent,

On 28/01/2019 11:26, Kieran Bingham wrote:
> Our maximum column limit is 120 characters, but we will still aim for an 80
> line boundary where it is possible. The 120 is a limit for exceptions.
> 

It seems that 80 is the clang-format default - so the fact that this
ColumnLimit is currently set to 0 puzzles me. (This means that
clang-format will not adjust the line length, unless it breaks some
other rule)

Perhaps it should at least be set to 120 ?

Was  "ColumnLimit 0"  a default in the file? or an intentional setting?



> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
>  .clang-format | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.clang-format b/.clang-format
> index 17eb095bde71..59a61d050e3d 100644
> --- a/.clang-format
> +++ b/.clang-format
> @@ -52,7 +52,7 @@ BreakConstructorInitializersBeforeComma: false
>  #BreakConstructorInitializers: BeforeComma # Unknown to clang-format-4.0
>  BreakAfterJavaFieldAnnotations: false
>  BreakStringLiterals: false
> -ColumnLimit: 0
> +ColumnLimit: 80
>  CommentPragmas: '^ IWYU pragma:'
>  #CompactNamespaces: false # Unknown to clang-format-4.0
>  ConstructorInitializerAllOnOneLineOrOnePerLine: false
> 

-- 
Regards
--
Kieran