[libcamera-devel] [PATCH v4 07/13] libcamera: controls: Add a set of initial controls

[Niklas Söderlund]

Hi Laurent,

On 2019-07-01 23:14:58 +0300, Laurent Pinchart wrote:
> Add an initial set of controls to demonstrate how controls are defined.
> 
> Proper documentation for each control is missing.

This could be improved moving forward, defining controls we know we need 
even with sparse documentation allows us to move forward.

> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

> ---
>  include/libcamera/control_ids.h |  6 +++++
>  src/libcamera/controls.cpp      | 42 +++++++++++++++++++++++++++++++++
>  2 files changed, 48 insertions(+)
> 
> diff --git a/include/libcamera/control_ids.h b/include/libcamera/control_ids.h
> index d0e700da9844..75b6a2d5cafe 100644
> --- a/include/libcamera/control_ids.h
> +++ b/include/libcamera/control_ids.h
> @@ -13,6 +13,12 @@
>  namespace libcamera {
>  
>  enum ControlId {
> +	AwbEnable,
> +	Brightness,
> +	Contrast,
> +	Saturation,
> +	ManualExposure,
> +	ManualGain,
>  };
>  
>  } /* namespace libcamera */
> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp
> index 42a2f8990bf6..d9fbd46d81c9 100644
> --- a/src/libcamera/controls.cpp
> +++ b/src/libcamera/controls.cpp
> @@ -186,6 +186,48 @@ std::string ControlValue::toString() const
>   * \brief Numerical control ID
>   */
>  
> +/**
> + * \var AwbEnable
> + * ControlType: Bool
> + *
> + * Enables or disables the AWB. See also \a libcamera::ControlId::ManualGain
> + */
> +
> +/**
> + * \var Brightness
> + * ControlType: Integer
> + *
> + * Specify a fixed brightness parameter.
> + */
> +
> +/**
> + * \var Contrast
> + * ControlType: Integer
> + *
> + * Specify a fixed constrast parameter.
> + */
> +
> +/**
> + * \var Saturation
> + * ControlType: Integer
> + *
> + * Specify a fixed saturation parameter.
> + */
> +
> +/**
> + * \var ManualExposure
> + * ControlType: Integer
> + *
> + * Specify a fixed exposure time in milli-seconds
> + */
> +
> +/**
> + * \var ManualGain
> + * ControlType: Integer
> + *
> + * Specify a fixed gain parameter
> + */
> +
>  /**
>   * \struct ControlIdentifier
>   * \brief Describe a ControlId with control specific constant meta-data
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

-- 
Regards,
Niklas Söderlund