[libcamera-devel] [RFC PATCH v2 1/7] libcamera: ipa_module_info: add license field

Paul Elder paul.elder at ideasonboard.com
Wed Jul 3 10:00:01 CEST 2019


Add a field to IPAModuleInfo to contain the license of the module.

Update the dummy IPA and IPA test to conform to the new struct layout

Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
---
New patch in v2
- this replaces the isolate flag that was used in v1

 include/libcamera/ipa/ipa_module_info.h | 2 ++
 src/ipa/ipa_dummy.cpp                   | 1 +
 src/libcamera/ipa_module.cpp            | 3 +++
 test/ipa/ipa_test.cpp                   | 1 +
 4 files changed, 7 insertions(+)

diff --git a/include/libcamera/ipa/ipa_module_info.h b/include/libcamera/ipa/ipa_module_info.h
index 585f753..39dca1a 100644
--- a/include/libcamera/ipa/ipa_module_info.h
+++ b/include/libcamera/ipa/ipa_module_info.h
@@ -18,6 +18,8 @@ struct IPAModuleInfo {
 	uint32_t pipelineVersion;
 	char pipelineName[256];
 	char name[256];
+	char license[64];
+
 } __attribute__((packed));
 
 extern "C" {
diff --git a/src/ipa/ipa_dummy.cpp b/src/ipa/ipa_dummy.cpp
index ee7a3a8..2e6ff71 100644
--- a/src/ipa/ipa_dummy.cpp
+++ b/src/ipa/ipa_dummy.cpp
@@ -34,6 +34,7 @@ const struct IPAModuleInfo ipaModuleInfo = {
 	0,
 	"PipelineHandlerVimc",
 	"Dummy IPA for Vimc",
+	"LGPLv2.1",
 };
 
 IPAInterface *ipaCreate()
diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp
index d82ac69..f786c16 100644
--- a/src/libcamera/ipa_module.cpp
+++ b/src/libcamera/ipa_module.cpp
@@ -215,6 +215,9 @@ elfLoadSymbol(void *map, size_t soSize, const char *symbol)
  *
  * \var IPAModuleInfo::name
  * \brief The name of the IPA module
+ *
+ * \var IPAModuleInfo::license
+ * \brief License of the IPA module
  */
 
 /**
diff --git a/test/ipa/ipa_test.cpp b/test/ipa/ipa_test.cpp
index bbef069..4c51034 100644
--- a/test/ipa/ipa_test.cpp
+++ b/test/ipa/ipa_test.cpp
@@ -59,6 +59,7 @@ protected:
 			0,
 			"PipelineHandlerVimc",
 			"Dummy IPA for Vimc",
+			"LGPLv2.1"
 		};
 
 		count += runTest("src/ipa/ipa_dummy.so", testInfo);
-- 
2.20.1



More information about the libcamera-devel mailing list