[libcamera-devel] [PATCH v3] libcamera: ipa_module: add path to module loading error message

[Niklas Söderlund]

Hi Paul,

Thanks for your work.

On 2019-07-03 22:58:25 +0900, Paul Elder wrote:
> Add an error message to tell, if an IPA module failed to load, the
> path to the IPA module shared object that was attempted to be loaded.
> 
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>

With Laurent's suggestions fixed,

Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

> ---
> Changes in v3:
> - error message wording change
> - moved to under the close: label
> 
> Changes in v2: don't show module version
> 
>  src/libcamera/ipa_module.cpp | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp
> index 58e8d1d..477f4b8 100644
> --- a/src/libcamera/ipa_module.cpp
> +++ b/src/libcamera/ipa_module.cpp
> @@ -289,6 +289,11 @@ int IPAModule::loadIPAModuleInfo()
>  unmap:
>  	munmap(map, soSize);
>  close:
> +	if (ret)
> +		LOG(IPAModule, Error)
> +			<< "Error loading IPA module "
> +			<< libPath_;
> +
>  	close(fd);
>  	return ret;
>  }
> -- 
> 2.20.1
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

-- 
Regards,
Niklas Söderlund