[libcamera-devel] [PATCH 8/9] libcamera: pipeline: ipu3: Use buffer mapping

[Niklas Söderlund]

Hi Jacopo,

Thanks for your work.

On 2019-07-05 00:53:33 +0200, Jacopo Mondi wrote:
> In order to support the usage of application provided buffer, retrieve
> the buffer to use on video devices using the Request in order to allow
> the stream to perform buffer mapping, if requested.
> 
> The IPU3 was the only pipeline handler to access the Request map
> directly instead of using Request::findBuffer().

I now see why we really wish to hide the buffers() method. I think we 
need to think hard on how to do that. But that could be done on-top of 
this work.

> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

> ---
>  src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
> index 28dcefe3d19f..49aa27ff20d4 100644
> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp
> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
> @@ -725,7 +725,7 @@ int PipelineHandlerIPU3::queueRequest(Camera *camera, Request *request)
>  
>  	for (auto it : request->buffers()) {
>  		IPU3Stream *stream = static_cast<IPU3Stream *>(it.first);
> -		Buffer *buffer = it.second;
> +		Buffer *buffer = request->findBuffer(stream);
>  
>  		int ret = stream->device_->dev->queueBuffer(buffer);
>  		if (ret < 0)
> -- 
> 2.21.0
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

-- 
Regards,
Niklas Söderlund